Skip to content

1559 only txlist rlp decode #38

1559 only txlist rlp decode

1559 only txlist rlp decode #38

Triggered via pull request August 16, 2023 05:49
Status Failure
Total duration 27s
Artifacts

openai-review.yml

on: pull_request
OpenAI PR Comment
15s
OpenAI PR Comment
Fit to window
Zoom out
Zoom in

Annotations

2 errors
OpenAI PR Comment
Unable to process file command 'env' successfully.
OpenAI PR Comment
Invalid format 'GIT_PATCH_OUTPUT=From e0e379085eb02129921919a7ee626305fed49744 Mon Sep 17 00:00:00 2001 From: smtmfft <[email protected]> Date: Mon, 10 Jul 2023 02:30:20 +0000 Subject: [PATCH 01/31] add rlp decode circuit --- circuit-benchmarks/src/lib.rs | 4 + circuit-benchmarks/src/rlp_decode_circuit.rs | 102 + zkevm-circuits/src/lib.rs | 2 + zkevm-circuits/src/rlp_decoder.rs | 3146 ++++++++++++++++++ zkevm-circuits/src/rlp_decoder_tables.rs | 764 +++++ 5 files changed, 4018 insertions(+) create mode 100644 circuit-benchmarks/src/rlp_decode_circuit.rs create mode 100644 zkevm-circuits/src/rlp_decoder.rs create mode 100644 zkevm-circuits/src/rlp_decoder_tables.rs diff --git a/circuit-benchmarks/src/lib.rs b/circuit-benchmarks/src/lib.rs index 4e4c994536..807034e8a8 100644 --- a/circuit-benchmarks/src/lib.rs +++ b/circuit-benchmarks/src/lib.rs @@ -38,3 +38,7 @@ pub mod exp_circuit; #[cfg(test)] //#[cfg(feature = "benches")] pub mod constants; + +#[cfg(test)] +#[cfg(feature = "benches")] +pub mod rlp_decode_circuit; \ No newline at end of file diff --git a/circuit-benchmarks/src/rlp_decode_circuit.rs b/circuit-benchmarks/src/rlp_decode_circuit.rs new file mode 100644 index 0000000000..bf0bd3150f --- /dev/null +++ b/circuit-benchmarks/src/rlp_decode_circuit.rs @@ -0,0 +1,102 @@ +//! RLP decode circuit benchmarks + +#[cfg(test)] +mod bench { + use super::*; + use ark_std::{end_timer, start_timer}; + use halo2_proofs::{ + halo2curves::bn256::{Bn256, Fr, G1Affine}, + plonk::{create_proof, keygen_pk, keygen_vk, verify_proof}, + poly::{ + commitment::ParamsProver, + kzg::{ + commitment::{KZGCommitmentScheme, ParamsKZG, ParamsVerifierKZG}, + multiopen::{ProverSHPLONK, VerifierSHPLONK}, + strategy::SingleStrategy, + }, + }, + transcript::{ + Blake2bRead, Blake2bWrite, Challenge255, TranscriptReadBuffer, TranscriptWriterBuffer, + }, + }; + use rand::SeedableRng; + use rand_chacha::ChaChaRng; + use std::env::var; + + #[test] + fn bench_rlp_decode_circuit_prover() { + let setup_prfx = "crate::constants::SETUP"; + let proof_gen_prfx = "crate::constants::PROOFGEN_PREFIX"; + let proof_ver_prfx = "crate::constants::PROOFVER_PREFIX"; + // Unique string used by bench results module for parsing the result + const BENCHMARK_ID: &str = "Rlp decode Circuit"; + + let degree: u32 = var("DEGREE") + .unwrap_or_else(|_| "18".to_string()) + .parse() + .expect("Cannot parse DEGREE env var as u32"); + + let mut rng = ChaChaRng::seed_from_u64(2); + let input_bytes = hex::decode("f850f84e8001830f4240808080820a97a0805d3057e9b74379d814e2c4d264be888a9b560ea2256781af8a6ea83af41208a07168d2b6d3aa47cbc5020c8a9b120926a197e1135b3aaa13ef0b292663345c15").unwrap(); + let circuit = RlpDecoderCircuit::<Fr>::new(input_bytes, degree as usize); + + // Bench setup generation + let setup_message = format!("{} {} with degree = {}", BENCHMARK_ID, setup_prfx, degree); + let start1 = start_timer!(|| setup_message); + let general_params = ParamsKZG::<Bn256>::setup(degree, &mut rng); + let verifier_params: ParamsVerifierKZG<Bn256> = general_params.verifier_params().clone(); + end_timer!(start1); + + // Initialize the proving key + let vk = keygen_vk(&general_params, &circuit).expect("keygen_vk should not fail"); + let pk = keygen_pk(&general_params, vk, &circuit).expect("keygen_pk should not fail"); + // Create a proof + let mut transcript = Blake2bWrite::<_, G1Affine, Challenge255<_>>::init(vec![]); + + // Bench proof generation time + let proof_message = format!( + "{} {} with degree = {}", + BENCHMARK_ID, proof_gen_prfx, degree + ); + let start2 = start_timer!(|| proof_message); + create_proof::< + KZGCommitmentScheme<Bn256>, + ProverSHPLONK<'_, Bn256>, + Challenge255<G1Affine>, + ChaChaRng, + Blake2bWrite<Vec<u8>, G1Affine, Challenge255<G1Affine>>, + RlpDecoderCircuit<Fr>, + >( + &general_params, + &pk, + &[circuit], + &[&[]], + rng, + &mut transcript, + ) + .expect("proof generation should not fail"); + let proof = transcript.finalize(); + end_timer!(start2); + + // Bench verification time + let start3 = start_timer!(|| format!("{} {}", BENCHMARK_ID, proof_ver_prfx)); + let