Do not send more than one request per peer at a time #779
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a "request lock" system to the
NetworkService
of the light client.When a "request lock" is held, no other request lock with the same PeerId can be created. A "request lock" can then be used to start an actual request.
This causes the
sync_service
(and all parts of the node) to only start one request per peer at a time.This effectively implements an existing requirement of the Polkadot networking protocol that isn't enforced by Substrate.
There are some caveats and further PRs will further refine this system:
chainHead_unstable_storage
paritytech/json-rpc-interface-spec#51 should be implemented.