Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Hearth unit test coverge for event streams. #214

Merged
merged 13 commits into from
Aug 14, 2024
Merged

Conversation

alextwoods
Copy link
Contributor

@alextwoods alextwoods commented Aug 5, 2024

Description of changes:
Full (100%) unit test coverage for event stream hearth components introduced in #206.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@alextwoods alextwoods marked this pull request as ready for review August 12, 2024 23:28
@alextwoods alextwoods changed the title Eventstreams 2 Improve unit test coverge for event streams. Aug 12, 2024
@alextwoods alextwoods changed the title Improve unit test coverge for event streams. Improve Hearth unit test coverge for event streams. Aug 12, 2024
@alextwoods alextwoods mentioned this pull request Aug 13, 2024
@@ -13,25 +13,8 @@
module Hearth
# Module for EventStreams.
module EventStream
# Raised when reading bytes exceed buffer total bytes
class ReadBytesExceedLengthError < RuntimeError; end
class MessageDecodeError < StandardError; end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change

@alextwoods alextwoods merged commit 848cf87 into main Aug 14, 2024
26 checks passed
@jterapin jterapin deleted the eventstreams_2 branch August 14, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants