Global config for Hearth clients #207
Conversation
|
TODO: test for global being overwritten (hierarchy?) and value validation |
codegen/smithy-ruby-codegen-test/integration-specs/client_spec.rb
Outdated
Show resolved
Hide resolved
| attr_reader :config | ||
|
|
||
| # @param [Hash] config | ||
| def config=(config) |
There was a problem hiding this comment.
While I do think global config is okay for AWS clients, I'm a little skeptical about supporting it for all generic Hearth clients - I think it could be a little bit of a foot gun if someone is using smithy-ruby clients for vastly different services.
There was a problem hiding this comment.
Maybe. Let's chat offline.
There was a problem hiding this comment.
If we do want to support generic global config - what about only supporting it in the generated SDK's namespace. Eg: RailsJson.config or AWS::SDK::S3.config?
There was a problem hiding this comment.
I think we will also need per-service global config and AWS global config, but I think Hearth global config is still fine here. Yes there are risks, and I understand it may seem funky, but I think it's correct to have config at every level.
Config defaults need to remain inside the Config struct and Config must expose the original provided options. This is so global config plugin knows what was configured already (it may be nil).
Needs tests and some more thought on approach. Options are being modified by resolver, it would be preferable not to.