Interceptors #137
Merged
Interceptors #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mullermp
reviewed
Jul 7, 2023
codegen/smithy-ruby-codegen-test/integration-specs/interceptor_spec.rb
Outdated
Show resolved
Hide resolved
mullermp
approved these changes
Jul 10, 2023
mullermp
approved these changes
Jul 11, 2023
| let(:client) { Client.new(config) } | ||
|
|
||
| it 'applies interceptors in expected order' do | ||
| expect(Plugins::TestPlugin::TEST_CLASS_INTERCEPTOR).to receive(hook).ordered |
There was a problem hiding this comment.
I think you can use any_instance_of with the above change.
There was a problem hiding this comment.
Wanted to be specific rather than use any_instance_of.
| let(:operation_interceptor) { interceptor_class.new('op') } | ||
|
|
||
| let(:config_plugin) do | ||
| proc { |cfg| cfg.interceptors << config_plugin_interceptor} |
There was a problem hiding this comment.
Space before } on this and below - we should enable rubocop styling/auto correct on spec files.
There was a problem hiding this comment.
ran rubocop on all of these. But we should long term find a way to run it on all of these integration specs, but not on generated gems....
...-codegen/src/main/java/software/amazon/smithy/ruby/codegen/middleware/MiddlewareBuilder.java
Show resolved
Hide resolved
| last_error | ||
| end | ||
|
|
||
| def dup |
There was a problem hiding this comment.
minimal @return docs for these
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds Interceptors to Hearth:
interceptor_hookmethod).VALIDATE). Updated host_prefix to to use Relative to (before) Build.Future PRs:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.