Freeze config on operation config

smithy-lang · Jul 8, 2024 · d660733 · d660733
1 parent ea12778
commit d660733
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 0 deletions.
diff --git a/codegen/smithy-ruby-codegen-test/integration-specs/client_spec.rb b/codegen/smithy-ruby-codegen-test/integration-specs/client_spec.rb
@@ -58,6 +58,7 @@ module WhiteLabel
 
       it 'uses config from options' do
         operation_config = { endpoint: 'https://example.com' }
+        expect_any_instance_of(Config).to receive(:freeze)
         expect_any_instance_of(Config)
           .to receive(:merge).with(operation_config)
           .and_call_original

diff --git a/hearth/lib/hearth/client.rb b/hearth/lib/hearth/client.rb
@@ -38,6 +38,7 @@ def initialize_config(options, config_class)
       config.plugins.each { |p| p.call(config) }
       config.interceptors.concat(client_interceptors)
       config.validate!
+      config.freeze
       config
     end
 
@@ -55,6 +56,7 @@ def operation_config(options)
       operation_plugins&.each { |p| p.call(config) }
       config.interceptors.concat(operation_interceptors)
       config.validate!
+      config.freeze
       config
     end
 

diff --git a/hearth/spec/hearth/client_spec.rb b/hearth/spec/hearth/client_spec.rb
@@ -92,6 +92,10 @@ def read_before_signing(*args); end
         client = Test::Client.new(interceptors: [interceptor])
         expect(client.config.interceptors.to_a).to include(interceptor)
       end
+
+      it 'freezes config' do
+        expect(subject.config.frozen?).to be(true)
+      end
     end
 
     describe '#inspect' do
@@ -130,6 +134,10 @@ def read_before_signing(*args); end
         config = subject.operation({}, interceptors: [interceptor])
         expect(config.interceptors.to_a).to eq([interceptor])
       end
+
+      it 'freezes config' do
+        expect(subject.operation.frozen?).to be(true)
+      end
     end
 
     describe '#output_stream' do