Fix rubocop and rspec issues

smithy-lang · Jun 29, 2023 · bb13cc6 · bb13cc6
1 parent 7cbb76e
commit bb13cc6
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 8 deletions.
diff --git a/codegen/projections/high_score_service/lib/high_score_service/client.rb b/codegen/projections/high_score_service/lib/high_score_service/client.rb
diff --git a/codegen/projections/rails_json/lib/rails_json/client.rb b/codegen/projections/rails_json/lib/rails_json/client.rb
diff --git a/codegen/projections/weather/lib/weather/client.rb b/codegen/projections/weather/lib/weather/client.rb
diff --git a/...codegen/src/main/java/software/amazon/smithy/ruby/codegen/generators/ClientGenerator.java b/...codegen/src/main/java/software/amazon/smithy/ruby/codegen/generators/ClientGenerator.java
@@ -161,7 +161,7 @@ private Object removeRbExtension(String s) {
 
     private void renderClassRuntimePlugins(RubyCodeWriter writer) {
         if (context.getRuntimePlugins().isEmpty()) {
-            writer.write("@plugins = []");
+            writer.write("@plugins = PluginList.new");
         } else {
             writer.openBlock("@plugins = Hearth::PluginList.new([");
             writer.write(

diff --git a/hearth/lib/hearth/plugin_list.rb b/hearth/lib/hearth/plugin_list.rb
@@ -1,10 +1,15 @@
+# frozen_string_literal: true
+
 module Hearth
+  # A list of plugins that can be applied to config. Plugins are callables
+  # that take one argument (config) and are called during client initialization
+  # or operation invocation to modify config.
   class PluginList
-
     def initialize(plugins = [])
       unless plugins.respond_to?(:each)
         raise ArgumentError, 'Plugins must be an enumerable'
       end
+
       @plugins = []
       plugins.each { |p| add(p) }
     end
@@ -14,14 +19,15 @@ def add(plugin)
         raise ArgumentError,
               'Plugin must be callable and take one argument (config)'
       end
+
       @plugins << plugin
     end
 
     def apply(config)
       @plugins.each { |p| p.call(config) }
     end
 
-    alias_method :<<, :add
+    alias :<< :add
 
     private
 

diff --git a/hearth/spec/hearth/plugin_list_spec.rb b/hearth/spec/hearth/plugin_list_spec.rb
@@ -15,7 +15,7 @@ module Hearth
 
       context 'proc with incorrect number of arguments' do
         let(:plugin) do
-          proc { }
+          proc {}
         end
 
         it 'raises an argument error' do
@@ -27,7 +27,7 @@ module Hearth
 
       context 'non-callable object' do
         let(:plugin) do
-          Class.new {}.new
+          Class.new.new
         end
 
         it 'raises an argument error' do