chore: refactor to put function name generator in constant #641
Conversation
rishav-karanjit
changed the title
| @@ -598,7 +600,7 @@ func Error_ToDafny(err error)($L.Error) { | |||
| } | |||
| """, | |||
| DafnyNameResolver.dafnyTypesNamespace(serviceShape), | |||
| writer.consumer(w -> { | |||
| writer.consumer(w -> { | |||
There was a problem hiding this comment.
Not sure how this came in diff but make format_java will fix this. So, Ignoring this for now.
There was a problem hiding this comment.
Personally I'm not a fan of our java formatter - it keeps line too short and I think uses 2 white-spaces for indentation.
rishav-karanjit
changed the title
rishav-karanjit
changed the title
| @@ -807,7 +809,7 @@ private void generateSerializerFunctions(final GenerationContext context, final | |||
| return $L | |||
| } | |||
| """, | |||
| ShapeVisitorHelper.funcNameGenerator( | |||
There was a problem hiding this comment.
nit: I'd prefer fully-qualified-name / FQN over static imports. Improves readability / reasoning around where this function belongs.
| @@ -598,7 +600,7 @@ func Error_ToDafny(err error)($L.Error) { | |||
| } | |||
| """, | |||
| DafnyNameResolver.dafnyTypesNamespace(serviceShape), | |||
| writer.consumer(w -> { | |||
| writer.consumer(w -> { | |||
There was a problem hiding this comment.
Personally I'm not a fan of our java formatter - it keeps line too short and I think uses 2 white-spaces for indentation.
| ) { | ||
| return memberShape | ||
| .getId() | ||
| .toString() | ||
| .replaceAll("[.$#]", "_") | ||
| .concat("_") | ||
| .concat(suffix); |
There was a problem hiding this comment.
Why is this different than one in the ValidationGenerator ?
There was a problem hiding this comment.
I thought the name in ValidationGenerator won't collide and will look good but the name collided (Caught in CI in 8738b87) So, I made ValidationGenerator to use same function name.
rishav-karanjit
changed the title
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.