Python: Update as_dict/from_dict #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * Override Smithy-Python writeAsDict to handle shapes with {@link ReferenceTrait}s. | ||
| * Most of this is lifted directly from Smithy-Python; the changed components are | ||
| * highlighted. |
There was a problem hiding this comment.
The whole thing is highlighted if you meant that the diff would be highlighted (In that case, it's better to remove the highlighted word).
There was a problem hiding this comment.
Oh no, by "highlighted" I meant that I was calling out specific areas.
But it is unclear. Let me clarify
|
CI doesn't need to pass for this PR, but it was easy to make it pass. I updated this branch with the latest python-reviewed branch, and now most CI is passing. The final check will pass after #541, which formats the file in this PR with the updated logic from this PR, so I'll merge #541 in after this PR goes in. |
ShubhamChaturvedi7
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.