Python: Timestamps for AWS SDKs #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,7 +19,7 @@ module SimpleTimestampImplTest { | |||
| modifies client.Modifies | |||
| ensures client.ValidState() | |||
| { | |||
| var dafnyTimestamp := "2024-06-11T12:34:56"; | |||
| var dafnyTimestamp := "2024-06-11T12:34:56Z"; | |||
There was a problem hiding this comment.
Just wondering, what version of python does the customer have to be in because until python 3.10, it does not support military time stamp (timestamp with Z on the end)
There was a problem hiding this comment.
3.11. This constraint comes from Smithy-Python
There was a problem hiding this comment.
I'll also note that I'm not even running SimpleTimestamp in Python, since I'm claiming that timestamps aren't supported for local services.
But the timestamp as-is is not ISO 8601 / RFC 3339 compatible, and there is complete consensus that any Dafny timestamps should be compatible with these specs.
rishav-karanjit
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.