-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Timestamps for AWS SDKs #508
Conversation
@@ -19,7 +19,7 @@ module SimpleTimestampImplTest { | |||
modifies client.Modifies | |||
ensures client.ValidState() | |||
{ | |||
var dafnyTimestamp := "2024-06-11T12:34:56"; | |||
var dafnyTimestamp := "2024-06-11T12:34:56Z"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering, what version of python does the customer have to be in because until python 3.10, it does not support military time stamp (timestamp with Z on the end)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.11. This constraint comes from Smithy-Python
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll also note that I'm not even running SimpleTimestamp in Python, since I'm claiming that timestamps aren't supported for local services.
But the timestamp as-is is not ISO 8601 / RFC 3339 compatible, and there is complete consensus that any Dafny timestamps should be compatible with these specs.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.