Python: Smithy-Dafny's StandardLibrary #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josecorella
reviewed
Jul 31, 2024
TestModels/dafny-dependencies/StandardLibrary/runtimes/python/pyproject.toml
Outdated
Show resolved
Hide resolved
...pendencies/StandardLibrary/runtimes/python/src/standard_library/internaldafny/extern/UTF8.py
Outdated
Show resolved
Hide resolved
josecorella
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
@protocolDefinitiontrait to localService. "Real" Smithy code generators generate code for protocols. (A canonical protocol is HTTP.) Polymorph-NET/Java are not "real" Smithy code generators and instead hardcode localService. However, Polymorph Python extends a "real" Smithy code generator (Smithy-Python). Applying this trait lets "real" Smithy code generators identify the localService trait as a valid protocol.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.