fix(Python): Handle docformatter exit codes (#588)

smithy-lang · Sep 18, 2024 · e0caa14 · e0caa14
1 parent 9dd74be
commit e0caa14
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/...on-codegen/src/main/java/software/amazon/smithy/python/codegen/DirectedPythonCodegen.java b/...on-codegen/src/main/java/software/amazon/smithy/python/codegen/DirectedPythonCodegen.java
@@ -361,7 +361,13 @@ private void formatDocstrings(FileManifest fileManifest) {
             return;
         }
         LOGGER.info("Running docformatter on generated code");
-        CodegenUtils.runCommand("python3 -m docformatter --recursive .", fileManifest.getBaseDir());
+        // docformatter exit codes:
+        // 0: docformatter did not make changes
+        // 1: docformatter made changes
+        // 2: Invalid docformatter usage (incorrect arguments, etc.)
+        // If docformatter returns exit codes 0 or 1, then exit 0 to CodegenUtils. Otherwise, exit 1.
+        CodegenUtils.runCommand(
+        "python3 -m docformatter --recursive --in-place .; [ $? -eq 0 ] || [ $? -eq 1 ] || exit 1", fileManifest.getBaseDir());
     }
 
     private void runMypy(FileManifest fileManifest) {