Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizations #1164

Merged
merged 5 commits into from
Sep 25, 2024
Merged

Optimizations #1164

merged 5 commits into from
Sep 25, 2024

Conversation

MarkCiliaVincenti
Copy link
Contributor

  • Encouraging use of System.Threading.Lock which will bring performance benefits in .NET 9.0+
  • Making use of some frozen collections
  • Generic optimizations

@MarkCiliaVincenti
Copy link
Contributor Author

@muratcakir

@muratcakir muratcakir merged commit 74809c1 into smartstore:main Sep 25, 2024
@muratcakir
Copy link
Contributor

Thank you for your contribution!

@MarkCiliaVincenti
Copy link
Contributor Author

@muratcakir to gain advantages from the .NET 9.0 locking it is recommended to multi-target net9.0 as well. Are you ready to do that given it is still at RC1?

@muratcakir
Copy link
Contributor

[...] it is recommended to multi-target net9.0 as well. Are you ready to do that given it is still at RC1?

No, we will wait for the stable version, which most likely will come after our V5.2 release. However, I have already integrated your Lock shim to ensure a smooth and effortless transition later.

@MarkCiliaVincenti
Copy link
Contributor Author

[...] it is recommended to multi-target net9.0 as well. Are you ready to do that given it is still at RC1?

No, we will wait for the stable version, which most likely will come after our V5.2 release. However, I have already integrated your Lock shim to ensure a smooth and effortless transition later.

OK, you might want to leave it in if you start only targeting .NET 9.0. It will not add the dependency for .NET 9.0+ due to the condition on the PackageReference, but in case someone wants to downgrade to .NET 8.0 (given it is LTS), it would continue working for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants