Support for odd-sized HEIC images #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enlarge the image by 1 pixel to create a HEIC. - Replace the size information in the HEIC's ispe box with the original size.
Workaround by #34, HEIC with a final size less than 100 will be processed as JPEG.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
odd size HEIC image output, it's truncated by 1 pixel.
ex) w=99,h=99,fo=heic => 98x98 heic output.
#31
This is a limitation of libheif & x265.
Probably for the convenience of YUV420 subsampling.
As a workaround, increase the size by 1 pixel to generate a HEIC image binary, and rewrite the size information of the ispe box in the binary to its original size.