-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TT-950] Support for more eth1 clients #859
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c consensus type selection
…nlink-testing-framework into tt_950_pow_clients
skudasov
approved these changes
Mar 14, 2024
Quality Gate failedFailed conditions |
kalverra
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with these EVM node ranges:
Plus a bunch of other changes to private Ethereum network builder:
Simplified version:
Or with TOML:
Added two custom tags to our custom docker image handling:
latest_available
latest_stable
If you use them as shown in the example above we will fetch list of releases from Github and then either select latest one (even if it's a draft or pre-release) or latest stable.
Other changes:
--fakepow
)consensus_type
is deprecated and replaced withethereum_version
with two possible values:eth1
andeth2
(as these better capture the idea); backward compatibility is maintained.EVMClient
now hasGetEthClient()
method that return underlayingethclient.Client
(fromgo-ethereum
)Tested in this core PR with this new pipeline ✅
Tested in this run that bumping
go-ethereum
would have failed, if tested with EVM node inv1.10.0
. ✅CCIP was tested with this branch here ✅