-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ship-3979] remove ws validation #1318
Conversation
|
||
// Ensure at least one of WS or HTTP URLs is available | ||
if !wsOk && !httpOk { | ||
return nil, fmt.Errorf("no RPC URLs found for '%s' network; at least one HTTP or WS RPC URL must be set", selectedNetworks[i]) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will fail if no ws endpoints are provided, no? why not use the same condition as in lib/config/network.go
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it passes due to the !wsOk && !httpOk
condition. But this does not take into consideration "only HTTP or both HTTP and WS are allowed". So yes I should use the same condition as in lib/config/network.go
.
Will update thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work!
Quality Gate failedFailed conditions |
Adds the possibility for networks and Seth to not have WSs.
Possible to run with HTTP only or WS. WS can only run when provided HTTP also.
Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The changes improve flexibility in network configuration, especially for environments where WebSocket (WS) endpoints may not be available. They enable Seth and the broader system to operate with only HTTP endpoints, aligning with practical deployment scenarios and enhancing compatibility and configuration validation.
What