Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-1824] decode all events in all contracts #1287

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

Tofel
Copy link
Contributor

@Tofel Tofel commented Oct 31, 2024

  • Fixes a bug, which resulted in not decoding events emitted from contracts other than the the transaction entrypoint, even if we had their ABIs
  • Added tests for ^^ case

Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

This update fixes a bug in the event decoding process and improves the project's structure by organizing contracts into more specific packages based on their functionalities. It also introduces new contracts and updates the Makefile to generate bindings for these contracts, enhancing the project's capabilities to interact with smart contracts more efficiently.

What

  • Added AbstractContractWithEvent.sol, TestContractOne.sol, and TestContractTwo.sol contracts along with their ABI and binary files to introduce new functionalities.
  • Updated the Makefile to generate bindings for new contracts, ensuring that the project can interact with these contracts through Go code.
  • Modified client.go to decode events from all contracts instead of only the transaction entry point contract, addressing a bug in the event decoding process.
  • Reorganized contract bindings into more specific packages (NetworkDebugContract and NetworkDebugSubContract) for better structure and readability.
  • Included changes in various test files to accommodate the new structure and functionality updates.

@cl-sonarqube-production
Copy link

cl-sonarqube-production bot commented Oct 31, 2024

@Tofel Tofel marked this pull request as ready for review October 31, 2024 15:27
@Tofel Tofel requested review from sebawo and a team as code owners October 31, 2024 15:27
@Tofel Tofel merged commit 7437e46 into main Oct 31, 2024
43 of 46 checks passed
@Tofel Tofel deleted the tt-1824_decode_events_from_all_tx branch October 31, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants