Fix order of RPC and wallet keys fetched from env vars #1150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the code in
lib/config/env.go
to use sorted keys when handling environment variables. Previously, the code was iterating over the environment variables in an arbitrary order, which could lead to inconsistent behavior. Now, thegetSortedEnvs
function has been added to sort the environment variables by key before processing them.Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The changes ensure consistency and predictability in how environment variables are read and processed by sorting them alphabetically. This facilitates better organization and potentially makes debugging easier when dealing with a large number of environment variables.
What
sort
package to enable sorting functionality.getSortedEnvs
which sorts environment variables by their keys before returning them. This function is now used in place of direct calls toos.Environ()
inReadEnvVarSlice_String
,readEnvVarGroupedMap
, andreadEnvVarSingleMap
functions.