-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix off-by-one bug that can be caught on sub-RPS profiles #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skudasov
temporarily deployed
to
integration
September 20, 2024 14:24
— with
GitHub Actions
Inactive
skudasov
temporarily deployed
to
integration
September 20, 2024 14:24
— with
GitHub Actions
Inactive
skudasov
temporarily deployed
to
integration
September 20, 2024 14:28
— with
GitHub Actions
Inactive
skudasov
had a problem deploying
to
integration
September 20, 2024 15:44
— with
GitHub Actions
Error
skudasov
had a problem deploying
to
integration
September 20, 2024 15:44
— with
GitHub Actions
Error
skudasov
force-pushed
the
wasp-ratelimit-no-slack
branch
from
September 20, 2024 15:46
4c6b5af
to
65ac30e
Compare
gheorghestrimtu
approved these changes
Sep 20, 2024
skudasov
temporarily deployed
to
integration
September 20, 2024 15:47
— with
GitHub Actions
Inactive
skudasov
temporarily deployed
to
integration
September 20, 2024 15:47
— with
GitHub Actions
Inactive
Quality Gate failedFailed conditions |
skudasov
temporarily deployed
to
integration
September 20, 2024 15:51
— with
GitHub Actions
Inactive
skudasov
had a problem deploying
to
integration
October 22, 2024 09:13
— with
GitHub Actions
Failure
skudasov
had a problem deploying
to
integration
October 22, 2024 09:17
— with
GitHub Actions
Failure
skudasov
had a problem deploying
to
integration
October 22, 2024 09:31
— with
GitHub Actions
Failure
Quality Gate failedFailed conditions |
skudasov
had a problem deploying
to
integration
October 22, 2024 09:35
— with
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a subtle race only when executing a low-load profile.
Added a regression test.
Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The changes enhance the load testing framework by refining the rate limiting mechanism and improving the generator's control flow. Specifically, it introduces a flag to start tracking run status, optimizes virtual user cloning with a new rate limiting configuration, and streamlines the execution loop to better handle the load test lifecycle.
What
NewExampleScenario
andClone
methods to useratelimit.New
withratelimit.WithoutSlack
for more precise rate limiting.RunStarted
atomic boolean toStats
struct to track the start status of the run.setupSchedule
torunExecuteLoop
andrunSchedule
torunScheduleLoop
to clarify their purposes.runExecuteLoop
andprocessSegment
to use the new rate limiter configurationratelimit.WithoutSlack
.pacedCall
method to check if the run has started before executing, adding early returns if paused or stopped.BenchmarkPacedCall
to callrunExecuteLoop
instead ofsetupSchedule
.