better comment for gas bumping function #1129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The changes made to the
client_builder.gofile enhance flexibility and clarity in setting transfer gas fees and gas bumping strategies for transactions. By allowing the specification of a transfer gas fee and modifying the defaults and behavior of gas bumping, these updates provide users with more control over transaction cost management and retry strategies.What
seth/client_builder.goWithTransferGasFeeto ensure the transfer gas fee is set across all network configurations, enhancing consistency.WithGasBumpingdocumentation and default behavior to indicate no retries by default, and clarified the usage of custom bumping strategy for more flexible transaction management.