Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builder disable bumps #1125

Merged
merged 6 commits into from
Sep 6, 2024
Merged

Builder disable bumps #1125

merged 6 commits into from
Sep 6, 2024

Conversation

Tofel
Copy link
Contributor

@Tofel Tofel commented Sep 6, 2024

What it does:

  • disables gas bumping for default client (safer)
  • prints tx confirmation timeout, when waiting for it to be mined
  • doesn't fail the creation of replacement transaction if we cannot get it by hash (which can happen if gas price is super low)

Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The changes made aim to improve transaction handling and configuration management in the Ethereum client implementation. Specifically, these adjustments enhance the logging of transaction timeouts, disable gas bumping retries by default for more predictable gas management, and refine error handling during transaction replacement to account for transactions not found, improving the robustness of the transaction sending process.

What

  • seth/client.go
    • Added logging for transaction timeout configuration in the WaitMined function to provide clearer insights during transaction awaiting.
  • seth/client_builder.go
    • Modified the GasBump configuration in the ClientBuilder to disable retries by default (Retries: 0). This change makes gas bumping behavior more predictable and configurable.
  • seth/retry.go
    • Adjusted error handling in prepareReplacementTransaction to specifically ignore "not found" errors, making the logic more precise in differentiating between genuinely pending transactions and those already processed or dropped. This change ensures that transaction replacement efforts are more accurately targeted and efficient.

@Tofel Tofel marked this pull request as ready for review September 6, 2024 11:31
@Tofel Tofel requested review from sebawo and a team as code owners September 6, 2024 11:31
@cl-sonarqube-production
Copy link

@Tofel Tofel merged commit d6bb3c8 into main Sep 6, 2024
45 of 46 checks passed
@Tofel Tofel deleted the builder_disable_bumps branch September 6, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants