fix deadlock that happens when fetching blocks #1118
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not decrease workgroup count on error :/
Tests executed:
Added a ticket to add tests: https://smartcontract-it.atlassian.net/browse/TT-1604
Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The changes enhance the error handling within the asynchronous block header fetching process by ensuring the wait group counter is decremented even when an error occurs during header retrieval. This prevents potential deadlocks by guaranteeing that the wait group's count is accurately managed, allowing the process to complete as intended.
What
wg.Done()
call in the error handling section of the asynchronous block header fetching function. This ensures that the wait group count is decremented in case of an error, preventing the goroutine from blocking indefinitely.wg.Done()
within the error handling to ensure the wait group is properly decremented upon an error, facilitating error handling in concurrent operations.