[TT-1517] add fluent waiting for pending transactions #1100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
Currently when we check whether an address has pending transactions (pending nonce) we only do it once and if it does, fails immediately. It would be better if we made it into a fluent wait that checks it for given
time.Duration
.I did update readmes and the builder, but did not add any new dedicated tests.
Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The changes enhance the flexibility and configurability of nonce management and pending transaction handling in the Seth blockchain client library. Specifically, they introduce a configurable timeout for pending nonce protection, allowing users to define how long the client should wait for pending transactions to be mined before considering nonce protection measures. Additionally, the changes improve documentation and code clarity around nonce protection and pending transaction management.
What
PendingNonceProtectionTimeout
to ensure the client has a fallback timeout value.WithProtections
method to accept a timeout parameter for pending nonce protection, allowing for more granular configuration.PendingNonceProtectionTimeout
to the configuration structure to store the timeout value for pending nonce protection.