-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
content: draft: Flesh out "Usage" threat #1191
Open
TomHennen
wants to merge
6
commits into
slsa-framework:main
Choose a base branch
from
TomHennen:issue_1182
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These threats generally match the threats for 'Artifact Publication' with the twist that the consumer must do the verification instead. Consumer verification may be simplified if a VSA was issued at publication time. fixes slsa-framework#1180 Signed-off-by: Tom Hennen <[email protected]>
Signed-off-by: Tom Hennen <[email protected]>
Signed-off-by: Tom Hennen <[email protected]>
Signed-off-by: Tom Hennen <[email protected]>
Signed-off-by: Tom Hennen <[email protected]>
There are two ways to look at the usage threat: 1. Can the attacker modify the software being delivered to a consumer. 2. Can the consumer use the software insecurly allowing an attacker to take advantage of that insecurity to exploit them. IMO 1 has the same solutions as 'G' (PR slsa-framework#1190). I could repeat them here under usage, but instead I've updated 'G' to include modification in transit, and I've had 'Usage' address 2 above (albeit by just deferring to CISA's work in this area). fixes slsa-framework#1182 Signed-off-by: Tom Hennen <[email protected]>
✅ Deploy Preview for slsa ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey @MarkLodato, if you have time can you take a quick look at 'I' in this PR and double-check my logic? I'd like to make sure I'm not missing anything (or if there's a good reason to include much of 'G' here too). Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two ways to look at the usage threat:
to take advantage of that insecurity to exploit them.
IMO 1 has the same solutions as 'G' (PR #1190). I could repeat them
here under usage, but instead I've updated 'G' to include modification
in transit, and I've had 'Usage' address 2 above (albeit by just
deferring to CISA's work in this area).
fixes #1182
NOTE: this PR is based on top of #1190 since the solution presented in 1190 obviates the need for addressing that here.