Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sub attributes2 #6749

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Sub attributes2 #6749

wants to merge 7 commits into from

Conversation

szecket
Copy link
Member

@szecket szecket commented Nov 8, 2024

made some finesse tweaks to the pre-existing layering and display layout for the preview pane

szecket and others added 7 commits November 8, 2024 17:40
It lets you select colors based on the sliders, but it will
*only* apply the color when you hit enter on the text field
with the color string...

Not nice, but at least it does not keep losing state as it
round-trips the change through the code and compiler and
gets the state reset all the time.
@szecket szecket requested a review from hunger November 8, 2024 21:14
@@ -5,6 +5,8 @@ import { DarkModeSwitch } from "DarkModeSwitch.slint";
import { SunMoonSwitch } from "SunMoonSwitch.slint";

export component AppWindow inherits Window {
property <string> test-text: "foo";

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not belong into a PR targeting the properties view.

width: 100%;
height: 100%;


window := Rectangle {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not belong into a PR targeting the properties view.

@hunger
Copy link
Member

hunger commented Nov 15, 2024

Sorry, I missed the unrelated changes in here earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants