Expand-properties #6738
Open
Expand-properties #6738
+204
−169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The commit messages are not helpful :-/ I guess it's fine if you squash the commits later: In this case the description of the PR will be used. Otherwise we will have "it hurts" in our history forever -- which does not explain anything about the change that is contained in that patch. |
|
Please remove the last change in this set ("It hurts"). It just adds a blank line, that should really not be necessary ;-) |
hunger
requested changes
Nov 8, 2024
|
|
||
| NameLabel { | ||
| property-information: property; | ||
| element-information: root.element-information; | ||
| } | ||
|
|
||
| spacing: EditorSpaceSettings.default-spacing; | ||
| padding-bottom: EditorSpaceSettings.default-spacing; |
There was a problem hiding this comment.
Ideally this would not be mixed in between Elements but be at the top of the block with all other properties.
Just a nit-pick :-)
| @@ -196,7 +196,52 @@ component FloatWidget inherits VerticalLayout { | |||
| } | |||
| } | |||
| } | |||
| component StringWidget inherits VerticalLayout { | |||
There was a problem hiding this comment.
Can you format this properly? The indentation is off in places.
|
Sorry. Literally what hurt was that commit message. I didn’t know how to create a PR other than when pushing so I added a blank line and pushed again…Sent from my iPhoneSent from my iPhoneOn Nov 8, 2024, at 6:43 AM, Tobias Hunger ***@***.***> wrote:
@hunger requested changes on this pull request.
In tools/lsp/ui/views/property-view.slint:
NameLabel {
property-information: property;
element-information: root.element-information;
}
- spacing: EditorSpaceSettings.default-spacing;
+ padding-bottom: EditorSpaceSettings.default-spacing;
Ideally this would not be mixed in between Elements but be at the top of the block with all other properties.
Just a nit-pick :-)
In tools/lsp/ui/views/property-view.slint:
@@ -196,7 +196,52 @@ component FloatWidget inherits VerticalLayout {
}
}
}
+component StringWidget inherits VerticalLayout {
Can you format this properly? The indentation is off in places.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
converted all property val blocks to widgets for next step and legibility