-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MSRV to 1.77 #6307
Update MSRV to 1.77 #6307
Conversation
(cbindgen update was also blocked by the msrv, but the upgrade fails to parse our source files because of mozilla/cbindgen#993 so i didn't update that.) |
e77e8f9
to
c04fa33
Compare
(Looks like derive_more doesn't compile in no_std context, so i also didn't update this dep) |
@@ -3,6 +3,25 @@ | |||
# Changelog | |||
All notable changes to this project are documented in this file. | |||
|
|||
## 1.9.0 - Unreleased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, unrelated? :) Some of those items will hopefully be in 1.8.1, instead of 1.9.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just wanted to not forget to add the MSRV in there so I did fill all entries.
But yes, when we cherry pick item we'll have to edit the changelog to remove the item which went in 1.8.1 if we do release a 1.8.1
ab9eaa1
to
985a441
Compare
81984cf
to
4fac546
Compare
4fac546
to
82730ee
Compare
if matches!(path_elem_expr, Expression::Struct { ty: Type::Struct { fields, .. }, .. } if fields.is_empty()) { | ||
::core::default::Default::default() | ||
quote!(sp::PathElement::Close) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
derive_more::From used to generate a From<()> for PathElement
because of the empty PathElement::Close, but that's no longer the case (imho for good reasons).
So just explicitly write Close in this special case anyway. (and rely of the impl From<T> for <T>
)
That's the version from March.