Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MSRV to 1.77 #6307

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Update MSRV to 1.77 #6307

merged 3 commits into from
Sep 26, 2024

Conversation

ogoffart
Copy link
Member

That's the version from March.

@ogoffart
Copy link
Member Author

(cbindgen update was also blocked by the msrv, but the upgrade fails to parse our source files because of mozilla/cbindgen#993 so i didn't update that.)

@ogoffart
Copy link
Member Author

ogoffart commented Sep 25, 2024

(Looks like derive_more doesn't compile in no_std context, so i also didn't update this dep)
Edit: it does, we just have to remove the default features.

@@ -3,6 +3,25 @@
# Changelog
All notable changes to this project are documented in this file.

## 1.9.0 - Unreleased
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, unrelated? :) Some of those items will hopefully be in 1.8.1, instead of 1.9.0?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just wanted to not forget to add the MSRV in there so I did fill all entries.
But yes, when we cherry pick item we'll have to edit the changelog to remove the item which went in 1.8.1 if we do release a 1.8.1

@ogoffart ogoffart force-pushed the olivier/msrv branch 4 times, most recently from 81984cf to 4fac546 Compare September 25, 2024 15:24
if matches!(path_elem_expr, Expression::Struct { ty: Type::Struct { fields, .. }, .. } if fields.is_empty()) {
::core::default::Default::default()
quote!(sp::PathElement::Close)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

derive_more::From used to generate a From<()> for PathElement because of the empty PathElement::Close, but that's no longer the case (imho for good reasons).
So just explicitly write Close in this special case anyway. (and rely of the impl From<T> for <T>)

@ogoffart ogoffart merged commit 8ac0c79 into master Sep 26, 2024
31 of 35 checks passed
@ogoffart ogoffart deleted the olivier/msrv branch September 26, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants