metal: work around texture swizzle bug in the github runner VM

slime73 · Apr 26, 2024 · 4a2a25f · 4a2a25f
1 parent d423def
commit 4a2a25f
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/src/modules/graphics/metal/Graphics.h b/src/modules/graphics/metal/Graphics.h
@@ -251,6 +251,8 @@ class Graphics final : public love::graphics::Graphics
 
 	DeviceFamilies families;
 
+	bool isVMDevice;
+
 }; // Graphics
 
 } // metal

diff --git a/src/modules/graphics/metal/Graphics.mm b/src/modules/graphics/metal/Graphics.mm
@@ -283,6 +283,7 @@ static inline void setSampler(id<MTLComputeCommandEncoder> encoder, Graphics::Re
 	, uniformBufferGPUStart(0)
 	, defaultAttributesBuffer(nullptr)
 	, families()
+	, isVMDevice(false)
 { @autoreleasepool {
 	if (@available(macOS 10.15, iOS 13.0, *))
 	{
@@ -296,6 +297,8 @@ static inline void setSampler(id<MTLComputeCommandEncoder> encoder, Graphics::Re
 		throw love::Exception("LOVE's Metal graphics backend requires macOS 10.15+ or iOS 13+.");
 	}
 
+	isVMDevice = [device.name containsString:@("Apple Paravirtual device")];
+
 #ifdef LOVE_MACOS
 	// On multi-GPU macOS systems with a low and high power GPU (e.g. a 2016
 	// Macbook Pro), the OS doesn't activate the high power GPU for final
@@ -1940,8 +1943,13 @@ static inline void advanceVertexOffsets(const VertexAttributes &attributes, Buff
 			// Requires texture swizzle support.
 			if (@available(macOS 10.15, iOS 13, *))
 			{
-				if (families.apple[1] || families.mac[2] || families.macCatalyst[2])
-					flags |= commonsample;
+				// As of early 2024, the VM device doesn't properly support texture swizzles
+				// (observed on GitHub's runners) which is required for LA8 support.
+				if (!isVMDevice)
+				{
+					if (families.apple[1] || families.mac[2] || families.macCatalyst[2])
+						flags |= commonsample;
+				}
 			}
 			break;
 		case PIXELFORMAT_RG16_UNORM: