Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source path to TemplateSyntaxError #96

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

astery
Copy link
Contributor

@astery astery commented Nov 28, 2023

Improves the error's visibility by adding a path to a source.

before:

== Compilation error in file lib/app_web/views/page_view.ex ==
** (Slime.TemplateSyntaxError) Unexpected indent
INPUT, Line 2, Column 0
  .panel-heading

after:

== Compilation error in file lib/app_web/views/page_view.ex ==
** (Slime.TemplateSyntaxError) Unexpected indent
lib/app_web/templates/page/_comments.html.slim, Line 2, Column 0
  .panel-heading

@astery astery requested a review from a team as a code owner November 28, 2023 12:50
Copy link
Member

@doomspork doomspork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and welcome @astery! If you have any additional changes, please do open PRs, would love to get some other folks involved in the project.

@doomspork
Copy link
Member

I will update CI today/tomorrow so this passes 👍

@astery
Copy link
Contributor Author

astery commented Nov 29, 2023

Thank you! I assume ci is failing because it expects a string as otp version instead of an integer, but I'm not sure didn't check that.

@doomspork doomspork merged commit ae3b6db into slime-lang:master Nov 29, 2023
0 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants