Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix indicator for current page and hydration mismatch #1842

Merged
merged 6 commits into from
Sep 2, 2024

Conversation

warmthsea
Copy link
Contributor

Before:

screenshots

After:

screenshots

Copy link

netlify bot commented Aug 26, 2024

Deploy Preview for slidev ready!

Name Link
🔨 Latest commit c40ee5b
🔍 Latest deploy log https://app.netlify.com/sites/slidev/deploys/66cd4b0f4628d400078afa20
😎 Deploy Preview https://deploy-preview-1842--slidev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Aug 26, 2024

commit: c40ee5b

create-slidev

pnpm add https://pkg.pr.new/slidevjs/slidev/create-slidev@1842

@slidev/client

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/client@1842

create-slidev-theme

pnpm add https://pkg.pr.new/slidevjs/slidev/create-slidev-theme@1842

@slidev/parser

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/parser@1842

@slidev/cli

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/cli@1842

@slidev/types

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/types@1842

Open in Stackblitz

@KermanX
Copy link
Member

KermanX commented Aug 26, 2024

<LinkInline link="guide/" /> is displayed as Why Slidev instead of Getting Started (although the target URL is correct)

@KermanX KermanX changed the title docs: fix directory active docs: fix indicator for current page Aug 26, 2024
@KermanX KermanX changed the title docs: fix indicator for current page docs: fix indicator for current page and hydration mismatch Sep 2, 2024
@KermanX KermanX merged commit 00f6b74 into slidevjs:main Sep 2, 2024
20 checks passed
@warmthsea warmthsea deleted the docs/fix-list-active branch September 2, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants