Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Django 3.2 support #251

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Drop Django 3.2 support #251

merged 1 commit into from
Jul 12, 2024

Conversation

hramezani
Copy link
Collaborator

No description provided.

@hramezani hramezani requested a review from slashmili July 12, 2024 11:58
slashmili
slashmili approved these changes Jul 12, 2024
View reviewed changes
Copy link
Owner

@slashmili slashmili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should bump the major version as well, what do you think?

@hramezani
Copy link
Collaborator Author

I think we should bump the major version as well, what do you think?

There is no code change. I think minor would be enough

@hramezani hramezani merged commit fe1ec8c into slashmili:main Jul 12, 2024
12 checks passed
@hramezani hramezani deleted the drop-django32 branch July 12, 2024 14:26
@slashmili
Copy link
Owner

I'm wondering if we might need to offer an unexpected fix for django 3.2 later on django-jalali 6.X version.

@hramezani
Copy link
Collaborator Author

I'm wondering if we might need to offer an unexpected fix for django 3.2 later on django-jalali 6.X version.

Ok, that makes sense. I will bump the major version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slashmili slashmili slashmili approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hramezani @slashmili