Fix for decoding reaction_added #83
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found another issue (see c4e2e9d) - so now this contains also a fix, not just a test. |
bwasty
force-pushed
the
fix_reaction_added
branch
from
fabda13
to
61b2abb
Compare
bwasty
changed the title
|
Just noting since I forgot to previously: I am following this and I'll take another look once the upstream changes are sorted and we get travis passing. Thanks for the contributions! |
mthjones
reviewed
May 15, 2017
| @@ -213,7 +213,7 @@ pub enum Event { | |||
| user: String, | |||
| reaction: String, | |||
| item: Box<reactions::ListResponseItem>, | |||
There was a problem hiding this comment.
As mentioned in the PR on slack-rs-api, this object should be replaced with the lighter-weight object as specified in the Slack event docs. No upstream change necessary! :)
There was a problem hiding this comment.
Makes sense, I'll do the changes later this week.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR with fix: slack-rs/slack-rs-api#43.
Added test case based on a real message that could not be parsed.