-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating API Generation #101
base: master
Are you sure you want to change the base?
Conversation
@brownjohnf @dvaerum @dten Any chance you folks have them time to help me testing? Also @dten feel free to have a look to check whether this goes into the right direction. |
Hey thanks for this gargantuan effort. It's gonna take me a few days to get some time to go through it. 😯😯😯 |
Three thoughts - One, merging in scraped results is probably still needed as the OpenAPI specs are super stale. Two, the 'correct_xx' methods that are empty seem like pure noise: given the use of a wildcard match anyway, I think it would be a much smaller codebase to maintain if only the exceptions were present. e.g. in codegen/src/adapt/admin/apps/mod.rs have fn Three, rather than pulling the openapi spec from the web, if we use a git submodule, we could have a fork where these fixes are applied as a patch to the JSON schema directly, rather than in code to the parsed data structure. This might make it easier to maintain and drop them as things get fixed. |
PR for #99
This is the first step for migrating to the openapi spec at https://api.slack.com/specs/openapi/v2/slack_web.json. From this brief first look, I guess that this will be a breaking change. But we will see.
ToDo:
Notes: