Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] separate windows CI element from unix based CI #209

Merged
merged 3 commits into from
Jul 13, 2023
Merged

Conversation

fkiraly
Copy link
Contributor

@fkiraly fkiraly commented Jul 13, 2023

Fixes #208, by replicating the sktime setup, which separates windows CI and unix based CI.

@fkiraly fkiraly added the maintenance Continuous integration, unit testing & package distribution label Jul 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2023

Codecov Report

Merging #209 (4bede7a) into main (a33be08) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #209   +/-   ##
=======================================
  Coverage   82.41%   82.41%           
=======================================
  Files          43       43           
  Lines        2832     2832           
=======================================
  Hits         2334     2334           
  Misses        498      498           

@fkiraly
Copy link
Contributor Author

fkiraly commented Jul 13, 2023

Hm, this seems to fix it, and the tests all run.

@fkiraly fkiraly merged commit 34e8679 into main Jul 13, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MNT] windows CI failing in conda setup step
2 participants