Skip to content

Commit

Permalink
[MNT] full support for python 3.13 (#372)
Browse files Browse the repository at this point in the history
Python 3.13 was released today. This PR adds full support for python
3.13:

* removes markers to skip sklearn incompatibility with rc
* changes tests to use 3.13 and not the rc
  • Loading branch information
fkiraly authored Oct 8, 2024
1 parent e75b89f commit 1df6f9f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, macOS-latest, windows-latest]
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13.0-rc.2"]
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]
steps:
- uses: actions/checkout@v4

Expand Down
6 changes: 3 additions & 3 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,10 @@ dependencies = []
all_extras = ["numpy", "pandas"]

dev = [
'scikit-learn>=0.24.0; python_version < "3.13" or sys_platform != "win32"', # todo 0.11.0 - check if windows 3.13 works, if yes, remove markers
"scikit-learn>=0.24.0",
"pre-commit",
"pytest",
"pytest-cov"
"pytest-cov",
]

linters = [
Expand Down Expand Up @@ -87,7 +87,7 @@ test = [
"numpy",
"scipy",
"pandas",
'scikit-learn>=0.24.0; python_version < "3.13" or sys_platform != "win32"', # todo 0.11.0 - check if windows 3.13 works, if yes, remove markers
"scikit-learn>=0.24.0",
]

[project.urls]
Expand Down

0 comments on commit 1df6f9f

Please sign in to comment.