Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] Test mps #1654

Closed
wants to merge 6 commits into from
Closed

[MNT] Test mps #1654

wants to merge 6 commits into from

Conversation

XinyuWuu
Copy link
Member

@XinyuWuu XinyuWuu commented Sep 5, 2024

Test MPS in Github runner.

@fkiraly
Copy link
Collaborator

fkiraly commented Sep 5, 2024

:-( seems not to work (yet)

@XinyuWuu
Copy link
Member Author

XinyuWuu commented Sep 6, 2024

:-( seems not to work (yet)

Yeah, I could not find a way to disable MPS. More specificly make this line return False:

https://github.com/pytorch/pytorch/blob/main/torch/backends/mps/__init__.py#L25

Underlying probably here:
https://github.com/pytorch/pytorch/blob/main/aten/src/ATen/mps/MPSDevice.mm#L77-L103

Copy link
Member

@fnhirwa fnhirwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @XinyuWuu and @fkiraly

I managed to disable mps accelerator using pytest.MonkeyPatch would you take a look at this PR #1648

@XinyuWuu
Copy link
Member Author

Fixed in #1648

@XinyuWuu XinyuWuu closed this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants