Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] add minimal dependency management utilities #1628

Merged
merged 8 commits into from
Aug 30, 2024
Merged

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Aug 29, 2024

Adds minimal utilities for dependency management, to determine the packages installed.

This will be used later in isolation of dependencies that could be soft dependencies.

Instead of dumping the new utils in the current utils file, a new folder utils is added, in which the current utils is moved one level lower, and a _dependencies submodule is also added.

@fkiraly fkiraly added the maintenance Continuous integration, unit testing & package distribution label Aug 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 90.01%. Comparing base (4df80af) to head (bb8f6a6).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
pytorch_forecasting/utils/_dependencies.py 0.00% 10 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1628      +/-   ##
==========================================
- Coverage   90.19%   90.01%   -0.19%     
==========================================
  Files          30       32       +2     
  Lines        4724     4736      +12     
==========================================
+ Hits         4261     4263       +2     
- Misses        463      473      +10     
Flag Coverage Δ
cpu 90.01% <16.66%> (-0.19%) ⬇️
pytest 90.01% <16.66%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fkiraly fkiraly merged commit bde7169 into master Aug 30, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants