Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] change image logging from matplotlib figure to binary image #1417

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

broomva
Copy link

@broomva broomva commented Oct 21, 2023

Description

This PR ...

Checklist

  • Linked issues (if existing)
  • Amended changelog for large changes (and added myself there as contributor)
  • Added/modified tests
  • Used pre-commit hooks when committing to ensure that code is compliant with hooks. Install hooks with pre-commit install.
    To run hooks independent of commit, execute pre-commit run --all-files

Make sure to have fun coding!

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution and apologies for the late review.

Can you kindly explain why the title of the PR included mlflow? From looking at the code, this just seems to change how the figures are logged - as PIL image instead of as raw matplotlib figure.

Is this more compatible with mlflow? It also should be an option rather than changing and hence breaking established behaviour.

@fkiraly fkiraly added the enhancement New feature or request label Sep 7, 2024
@fkiraly fkiraly changed the title Added MLFlow Logger [ENH] change image logging from matplotlib figure to binary image Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants