Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardise on UTF-8 when converting strings to/from bytes #839

Merged
merged 3 commits into from
May 19, 2024

Conversation

pjfanning
Copy link
Contributor

issue is that if you don't specify the charset, the default is machine specific

@pjfanning
Copy link
Contributor Author

Apologies, the code didn't compile in Java 8. I was testing locally with a newer Java version. I have added a commit that I think should fix the compile issues.

@sksamuel sksamuel merged commit 80b243d into sksamuel:master May 19, 2024
1 check passed
@sksamuel
Copy link
Owner

lgtm

@pjfanning pjfanning deleted the StandardCharsets branch May 19, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants