Commits on Jul 12, 2022

1. Checkpoint dirname argument can also be a callable …

   Solves #848
   
   Description
   
   As of now, dirname can only be a string. With this update, it can also
   be a callable with no arguments that returns a string.
   
   What this solves is that the directory that a model is saved in can now
   contain a dynamic element. This way, if you run, e.g., grid search with
   n_jobs>1 + checkpoint, each checkpoint instance can have its own
   directory name (e.g. using a function that retuns a random name), while
   the files inside the directory still follow the same naming.
   
   Without such a possibility, if a user runs grid search with n_jobs>1 and
   checkpoint with load_best=True, the loaded model would always be
   whatever happens to be the latest one stored, which can result
   in (silent) errors.
   
   Implementation
   
   As a consequence of the dirname now not being known at __init__ time, I
   removed the validation of the filenames from there. We still validate
   them inside initialize(), which is sufficient in my opinion.
   
   In theory, we could call the dirname function inside __init__ to
   validate it, and then call it again inside initialize to actually set
   it, but I don't like that. The reason is that we would call a
   function that is possible non-deterministic or might have side effects
   twice, with unknown consequences. This should be avoided if possible.

   

   BenjaminBossan committed Jul 12, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 1daddb4
   • Browse repository at this point

   Copy the full SHA

   1daddb4 View commit details

   Browse the repository at this point in the history