Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting normalization #49

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Correcting normalization #49

wants to merge 4 commits into from

Commits on Jul 26, 2024

  1. Fixed normalization

    Now the variable normalize gets the value False when the user specifies vmin and vmax.
    vmin and vmax can be defined when using
    mp.plot(...,  shading = {"normalize" = [vmin, vmax]}, ...)
    If nothing is set by the user the standard value is 
    "normalize" = [None, None].
    If any of the two entries are None, then the variable normalize in Viewer.py gets the value True, and vmin and vmax are chosen inside utils.py in get_colors.
    mvlier authored Jul 26, 2024
    Configuration menu
    Copy the full SHA
    f8b8665 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2024

  1. Changed condition for normalize

    We don't need the variable normalize, since the condtion in get_colors can be written based on vmin and vmax
    mvlier authored Jul 27, 2024
    Configuration menu
    Copy the full SHA
    62a198e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1ab564e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    92b33f8 View commit details
    Browse the repository at this point in the history