add itemSpace BindingAdapter for dp sample

sjjeong · Nov 24, 2019 · 2f93737 · 2f93737
1 parent 4b20230
commit 2f93737
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 3 deletions.
diff --git a/app/src/main/res/layout/activity_mvp.xml b/app/src/main/res/layout/activity_mvp.xml
@@ -35,7 +35,7 @@
             app:layoutManager="androidx.recyclerview.widget.GridLayoutManager"
             app:spanCount="3"
             bind:dino_itemLayout="@{@layout/item_vector_asset}"
-            bind:dino_itemSpace="@{8}"
+            bind:dino_itemSpace="@{`8dp`}"
             bind:dino_items="@{items}"
             tools:itemCount="10"
             tools:listitem="@layout/item_vector_asset" />

diff --git a/app/src/main/res/layout/activity_mvvm.xml b/app/src/main/res/layout/activity_mvvm.xml
@@ -29,7 +29,7 @@
             app:layoutManager="androidx.recyclerview.widget.StaggeredGridLayoutManager"
             app:spanCount="3"
             bind:dino_itemLayout="@{@layout/item_vector_asset}"
-            bind:dino_itemSpace="@{8}"
+            bind:dino_itemSpace="@{`8dp`}"
             bind:dino_items="@{vm.vectorAssetItems}"
             tools:itemCount="10"
             tools:listitem="@layout/item_vector_asset" />

diff --git a/app/src/main/res/layout/activity_normal.xml b/app/src/main/res/layout/activity_normal.xml
@@ -34,7 +34,7 @@
             android:layout_height="match_parent"
             app:layoutManager="androidx.recyclerview.widget.LinearLayoutManager"
             bind:dino_itemLayout="@{@layout/item_vector_asset}"
-            bind:dino_itemSpace="@{8}"
+            bind:dino_itemSpace="@{@dimen/space}"
             bind:dino_items="@{items}"
             tools:itemCount="10"
             tools:listitem="@layout/item_vector_asset" />

diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml
@@ -0,0 +1,6 @@
+<?xml version="1.0" encoding="utf-8"?>
+<resources>
+
+    <dimen name="space">8dp</dimen>
+
+</resources>