Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding finetuning llms notebook #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pavanbelagatti
Copy link

No description provided.

Copy link
Collaborator

@kesmit13 kesmit13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to run the pre-commit checks on your fork. The notebook JSON code doesn't look formatted properly.

I'm not sure how this notebook fits in with the rest of our collection. I don't see that SingleStoreDB is even used. Is there some connection that needs to be made to our software here?

Other issues:

  1. You have a typo in the first line of the first section: "Singn" should be "Sign on"
  2. You should put a link to the Gradient web site where the sign up is required.
  3. The end of the first paragraph has some wording issues as well. The words in parens I believe should be "(we use them later on in this tutorial)". There is also a missing period.
  4. You should add spaces around the '=' in the cell setting the env vars.
  5. In the paragraph about fine-tuning the base model, you use the word "hallucinated". I'm not quite sure what you mean by that. Is there another word you could use? Maybe "unintelligible"?
  6. There should commas after 'complete' and 'relevant' in the second to the last sentence in that same paragraph.
  7. You should remove the main function from the last cell and split the cell into more digestible chunks, then add some descriptions to each step of the process.

@pavanbelagatti
Copy link
Author

@kesmit13 Can I please get some help here to push this one?

@kesmit13
Copy link
Collaborator

@pavanbelagatti I posted some comments about fixes that need to be addressed yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants