[c++] Corner-case bug in extend-enumeration logic #2897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jp-dark
approved these changes
Aug 16, 2024
johnkerl
force-pushed
the
kerl/subset-enum-fix
branch
from
9a7583c
to
6678073
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2897 +/- ##
==========================================
+ Coverage 89.88% 90.03% +0.15%
==========================================
Files 37 37
Lines 3925 3925
==========================================
+ Hits 3528 3534 +6
+ Misses 397 391 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
github-actions bot
pushed a commit
that referenced
this pull request
Aug 16, 2024
* Add Python unit-test coverage * run `make format` * [c++] Corner-case bug in extend-enumeration logic * lint
johnkerl
added a commit
that referenced
this pull request
Aug 16, 2024
* Add Python unit-test coverage * run `make format` * [c++] Corner-case bug in extend-enumeration logic * lint Co-authored-by: John Kerl <[email protected]>
Merged
jp-dark
pushed a commit
that referenced
this pull request
Aug 21, 2024
* Add Python unit-test coverage * run `make format` * [c++] Corner-case bug in extend-enumeration logic * lint
This was referenced Sep 13, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context: Fixes issue #2896.
Changes: Remap indices whether or not the enumeration is extended, as shown in the unit-test example added here.
Notes for Reviewer: