reorder, comment test cases

single-cell-data · Aug 8, 2024 · ba1f133 · ba1f133
1 parent 44402c6
commit ba1f133
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/apis/python/tests/test_registration_mappings.py b/apis/python/tests/test_registration_mappings.py
@@ -215,19 +215,25 @@ def soma_larger(anndata_larger):
     [          "index_col_and_name"      ,  "default_index_name"  ,  "signature_col_names"  ],
     [   # |   Set this   |  If present,  |     signatures.py      |        Expected:        |
         # |  col as idx  | rename index  |  `default_index_name`  |   signature col names   |
+
+        # `default_index_name` matches column that was made index ⇒ both columns present in signature
         [ (   "obs_id"   ,               ),       "obs_id"        , ( "obs_id" , "alt_id" ) ],
         [ (   "obs_id"   ,    "index"    ),       "obs_id"        , ( "obs_id" , "alt_id" ) ],
         [ (   "obs_id"   ,      None     ),       "obs_id"        , ( "obs_id" , "alt_id" ) ],
-        [ (   "alt_id"   ,               ),       "obs_id"        , ( "obs_id" , "alt_id" ) ],
-        [ (   "alt_id"   ,    "index"    ),       "obs_id"        , ( "obs_id" ,          ) ],
-        [ (   "alt_id"   ,      None     ),       "obs_id"        , ( "obs_id" ,          ) ],
-        [ (      None    ,               ),       "obs_id"        , ( "obs_id" , "alt_id" ) ],
         [ (   "alt_id"   ,               ),       "alt_id"        , ( "alt_id" , "obs_id" ) ],
         [ (   "alt_id"   ,    "index"    ),       "alt_id"        , ( "alt_id" , "obs_id" ) ],
         [ (   "alt_id"   ,      None     ),       "alt_id"        , ( "alt_id" , "obs_id" ) ],
+
+        # `default_index_name` is the column that was not made index ⇒ index dropped when named "index" or None
+        [ (   "alt_id"   ,               ),       "obs_id"        , ( "obs_id" , "alt_id" ) ],
+        [ (   "alt_id"   ,    "index"    ),       "obs_id"        , ( "obs_id" ,          ) ],
+        [ (   "alt_id"   ,      None     ),       "obs_id"        , ( "obs_id" ,          ) ],
         [ (   "obs_id"   ,               ),       "alt_id"        , ( "alt_id" , "obs_id" ) ],
         [ (   "obs_id"   ,    "index"    ),       "alt_id"        , ( "alt_id" ,          ) ],
         [ (   "obs_id"   ,      None     ),       "alt_id"        , ( "alt_id" ,          ) ],
+
+        # default RangeIndex ⇒ columns are preserved
+        [ (      None    ,               ),       "obs_id"        , ( "obs_id" , "alt_id" ) ],
         [ (      None    ,               ),       "alt_id"        , ( "alt_id" , "obs_id" ) ],
     ]
 )