Fix tests + fix lint issues + apply consistent formatting with Black + Dockerise #86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
I wanted to implement a new feature, but couldn't run the tests properly (as right now they need an unspecified Postgres setup to be done beforehand) so ended up creating a reproducible setup with Docker. While doing it I also applied consistent formatting using Black, which then made it possible to lint it with Flake8.
With these changes linting the code and running the whole test suite is as simple as
make docker-ci
with the only dependency being Docker, ie you don't even have to have Postgres running on your machine.I appreciate that this PR is huge so no offense if you don't want it, but I thought I should at least offer it.
Actually realised a couple of smaller changes from our fork snuck in too, namely using
psycopg2-binary
and handling geo features withshapely
.QA steps
Risks
Rollback steps