Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests + fix lint issues + apply consistent formatting with Black + Dockerise #86

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

daaain
Copy link

@daaain daaain commented Mar 10, 2020

Description of change

I wanted to implement a new feature, but couldn't run the tests properly (as right now they need an unspecified Postgres setup to be done beforehand) so ended up creating a reproducible setup with Docker. While doing it I also applied consistent formatting using Black, which then made it possible to lint it with Flake8.

With these changes linting the code and running the whole test suite is as simple as make docker-ci with the only dependency being Docker, ie you don't even have to have Postgres running on your machine.

I appreciate that this PR is huge so no offense if you don't want it, but I thought I should at least offer it.

Actually realised a couple of smaller changes from our fork snuck in too, namely using psycopg2-binary and handling geo features with shapely.

QA steps

  • automated tests passing
  • manual qa steps passing (list below)

Risks

Rollback steps

  • revert this branch

@cmerrick
Copy link

Hi @daaain, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@cmerrick
Copy link

You did it @daaain!

Thank you for signing the Singer Contribution License Agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants