-
-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Suricata #2454
Add Suricata #2454
Conversation
This project lints correctly: ``` $ npx awesome-lint ✔ Linting $ ``` and has been out there for 30 days. Let's get it into the list! :)
|
Thanks for making an Awesome list! 🙌 It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome. |
Thanks! Awaiting reviews. 👍🏻
Huh. I can't find anything obvious, even after going through the list multiple times. Just to be safe, I did the following changes:
Note that there is no logo because I don't want to use possibly copyrighted project logos (that would potentially make the list look like it's officially created or endorsed by the project team) and the requirements just say "have a logo wherever possible" which does not sound like a hard requirement. If it is, please mention it explicitly. If there's anything else, just let me know. |
After reaching out to the OISF/Suricata team and confirming that I am permitted to use it, provided I do not alter the logo in any way, I now also added a logo including a link back to the Suricata home page https://suricata.io. |
Just resolved the merge conflict that came up in the meantime. I am curious: Any other feedback so far? Is there anything else I can do to move this forward? |
Hello? Does anyone actually check any updates here? From what I can see, I have addressed all points in the requirements that might be debatable even in the slightest sense. If there is anything left for me to do, please let me know. A one-word pointer would do, no need for any detailed explanation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The list seems to follow the requirements.
It would be good to explicitly state the words IDS and IPS, as acronyms can be confusing.
Thanks a lot for the review, I was already thinking this was stalled :) If you're happy with the list now, could you also please approve this PR to have it count against some minimum approval requirements to be considered to merge? |
Linkify |
Done. |
Co-authored-by: Sindre Sorhus <[email protected]>
Thanks a lot for making this happen! |
This project lints correctly:
and has been out there for 30 days. Let's get it into the list! :)
https://github.com/satta/awesome-suricata#readme
This list contains resources in support of Suricata, a Free intrusion detection/prevention system and Network Security Monitoring engine. Suricata is a state of the art software tool that is used by many organizations, and that has spawned an active community of users and developers providing software, information and rulesets to support Suricata's mission.
As a member of that community, I compiled this list to gather these resources and create some visibility for the awesome projects out there!
My 2 reviews:
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions.
Add Name of List
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
add Swift
Adding Swift
Added Swift
- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
#readme
.- [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.main
, notmaster
.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Contents
, notTable of Contents
.Contributing
orFootnotes
sections.https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0
(replace<user>
and<repo>
accordingly).license
orLICENSE
in the repo root with the license text.Licence
section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.unicorn
.contributing.md
. Casing is up to you.Contributing
, positioned at the top or bottom of the main content.Footnotes
section at the bottom of the readme. The section should not be present in the Table of Contents.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use Travis for list linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.