validate link children separately: used for link and linkref

sindresorhus · Jan 2, 2024 · bfa29a3 · bfa29a3
1 parent ea4a4a8
commit bfa29a3
Showing 1 changed file with 14 additions and 8 deletions.
diff --git a/rules/list-item.js b/rules/list-item.js
@@ -119,15 +119,28 @@ function validateList(list, file) {
 			continue;
 		}
 
+		if (!validateListItemLinkChildren(link, file)) {
+			continue;
+		}
+
 		validateListItemDescription(description, file);
 	}
 }
 
+function validateListItemLinkChildren(link, file) {
+	for (const node of link.children) {
+		if (!listItemLinkNodeAllowList.has(node.type)) {
+			file.message('Invalid list item link', node);
+			return false;
+		}
+	}
+   return true;
+}
+
 function validateListItemLink(link, file) {
 	// NB. We need remark-lint-no-undefined-references separately
 	// to catch if this is a valid reference. Here we only care that it exists.
 	if (link.type === 'linkReference') {
-		// TODO: need to test link children against listItemLinkNodeAllowList?
 		return true;
 	}
 
@@ -147,13 +160,6 @@ function validateListItemLink(link, file) {
 		return false;
 	}
 
-	for (const node of link.children) {
-		if (!listItemLinkNodeAllowList.has(node.type)) {
-			file.message('Invalid list item link', node);
-			return false;
-		}
-	}
-
 	return true;
 }