Correct Day of Week Parsing #184
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class states that Sunday is 0, but then uses 'MO' as the first element of the array. As a result, the `$weekday` is wrong, and is one day off.
|
This causes lots of test failures. I don't have time to look in to the issue right now. If you do, you can run the tests with |
|
I will attempt to have a go at it probably next week. |
williamdes
reviewed
Dec 24, 2021
| @@ -41,7 +41,7 @@ class Weekday | |||
| /** @var int nth occurrence of the weekday */ | |||
| public $num; | |||
|
|
|||
| protected $days = array('MO', 'TU', 'WE', 'TH', 'FR', 'SA', 'SU'); | |||
| protected $days = array('SU', 'MO', 'TU', 'WE', 'TH', 'FR', 'SA'); | |||
There was a problem hiding this comment.
Is there an RFC that says what day is first ? (even if $weekday says 0 is Sunday)
|
I got into problems regarding the issue too. Here is my solution: #203 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class states that Sunday is 0, but then uses 'MO' as the first element of the array. As a result, the
$weekdayis wrong, and is one day off.