Push to PHP 7.2

[tvdijen]

Minimum version is PHP 7.2

Upgrades PHPunit to 7.x

[coveralls]

Coverage decreased (-0.1%) to 66.557% when pulling 49d39e8 on php71 into 7d7fd4d on master.

[tvdijen]

HHVM is now definitely broken because PHPcpd relies on Symfony4..

[jaimeperez]

Excellent job! I've noticed a couple of issues with properties losing their null default, but other than that, looks good to me! 👍 (I should probably admit that I haven't reviewed everything in detail though, due to the size of the PR).

[tvdijen]

Psalm really doesn't like those assertions... And neither do I..
What a mess to get the tests to pass again

[jaimeperez]

It makes sense, after all. It's not checking the source code for the webmozart/assert library, so it doesn't have any possible way to know that after the assertion, the variable is guaranteed to have a value.

In any case, I'd say psalm is serving its purpose very well... 😄

[tvdijen]

Can we specifically include the webmozart source to prevent these kind of issues in the future?

[jaimeperez]

If it passes the psalm tests, that could be a good idea, yes. I was already thinking about it, but I'm not sure it would pass. Also, if it breaks at some point, our builds would break with nothing we can do to fix them...

[tvdijen]

Changes to the webmozart library are minimal, looking at their history.. I'd say we go for it.
Worst case scenario, we have to suppress (or cast to info) specific errors on a per-file basis.

Given the nature of the xmlseclibs library, we may want to include that one too. Also not a library that has too many changes.

[jaimeperez]

xmlseclibs is failing hard nowadays. I submitted a PR to fix the issues, but would need that merged (and psalm integrated as part of the build process as well) before we can include it in our own tests.

[tvdijen]

How do you feel about writing our own Stub-files for XMLSecLibs and Webmozart? As an alternative to including them in the Psalm-config. This is also really useful for SSP, for PHP-libs like ldap and radius..

[tvdijen]

OK, stubs are nice for php-libs, not for the webmozart asserts.
Also, including the vendor/webmozart/assert dir to the project didn't have the expected result

Issues were addressed